Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to bypass untagged CLI versions to integration test code properly #1526

Closed
aaronkanzer opened this issue Nov 15, 2024 · 4 comments

Comments

@aaronkanzer
Copy link
Member

While developing #1519, it was not possible to bypass version checks when testing via the workflow described here: #1519 (comment)

This is due to:

  1. the untagged nature of the built CLI tool, where a proper semantic version is not issued
  2. The /info endpoint being hit (whether staging or prod) does not recognize the untagged version either

A plausible solution here would be to introduce a --bypass-version-validation flag into the CLI, so that testing against a production/staging environment can occur without commenting out code -- as displayed, for instance, here: #1519 (comment)

Let me know your thoughts @jwodder @yarikoptic -- perhaps you already have a workflow here that is yet to be documented -- thanks in advance

Cc @kabilar

@jwodder
Copy link
Member

jwodder commented Nov 15, 2024

I believe the problem comes from the fact that your fork at https://github.com/aaronkanzer/dandi-cli does not have any tags for some reason. Fix that, and then pip-installing the fork should result in an actual version.

@aaronkanzer
Copy link
Member Author

I believe the problem comes from the fact that your fork at https://github.com/aaronkanzer/dandi-cli does not have any tags for some reason. Fix that, and then pip-installing the fork should result in an actual version.

I can do that -- however, this would force every other fork to do this setup, outside of just writing code

@jwodder
Copy link
Member

jwodder commented Nov 15, 2024

@aaronkanzer I suspect this happened because you had "Copy the master branch only" checked when creating the fork. Without that, it'll work fine.

@aaronkanzer
Copy link
Member Author

@aaronkanzer I suspect this happened because you had "Copy the master branch only" checked when creating the fork. Without that, it'll work fine.

Thanks @jwodder -- that did work indeed - closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants