New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow NavItem to accept regular element props (e.g. onClick) #280

Open

JakeSidSmith opened this issue Sep 26, 2018 · 1 comment

Labels

bug

Contributor

JakeSidSmith commented Sep 26, 2018

Currently NavItem does not accept any props other than the few defined in it's interface.

It might make sense to allow people to give it regular props.

JakeSidSmith added the bug label

Contributor Author

JakeSidSmith commented Sep 26, 2018

Update: this is actually a bug.

Accepts regular html attributes
https://github.com/dabapps/roe/blob/master/src/ts/components/navigation/nav-item.tsx#L6

But does not apply ...remainingProps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment