Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh doesn't get merged with NaNimation when object's default state is off #126

Open
qbitzvr opened this issue Oct 2, 2024 · 4 comments

Comments

@qbitzvr
Copy link

qbitzvr commented Oct 2, 2024

I have a VRCFury Toggle configured in the image below. The intended behavior is to swap between two states and sync the objects being toggled exclusively. As a result, one of the toggles is off by default. However, it seems the optimizer doesn't detect this from being able to use nanimation to merge the mesh. When I remove exclusivity and their default state on, mesh merging works.
image

@d4rkc0d3r
Copy link
Owner

Do you have Keep Default Enabled State enabled?
Because that setting specifically stops meshes with different default state to get merged with NaNimation Toggles. Without that it will merge them and then the meshes will all be enabled if someone has your animations blocked with the safety settings.

@qbitzvr
Copy link
Author

qbitzvr commented Oct 2, 2024

Either with Keep Default Enabled State enabled or disabled, it doesn't merge the meshes. This is what it looks like in play mode:
image

In VRCFury I can use Show when animator disabled and then it fixes the initial problem of merging the mesh. But this will make it so it's always shown whether or not Keep Default Enabled State is set.
image

@d4rkc0d3r
Copy link
Owner

d4rkc0d3r commented Oct 3, 2024

Oh are you doing WD ON? Fury should have a component to make the animator WD OFF, try that.

NaNimation toggles specifically states:

It can't merge meshes that use a WD ON workflow when they are off by default unless the toggles are simple enough that they can get optimized by Optimize FX Layer

Edit: It specifically checks if there is any layer that has only bindings for turning the mesh off but not on and vice versa. Though now that I think about it only a stray state turning it only on should be a problem and it should allow stray states that only turn it off.

d4rkc0d3r added a commit that referenced this issue Oct 6, 2024
@qbitzvr
Copy link
Author

qbitzvr commented Oct 17, 2024

Hi,

I did WD OFF but it still didn't work.
image

Keep Default Enabled State is also enabled
image

But the default off meshes still don't merge:
image

This is with version 3.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants