Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iohub appending does not change or raise warning regarding datatype #187

Open
edyoshikun opened this issue Sep 11, 2023 · 1 comment
Open
Labels
NGFF OME-NGFF (OME-Zarr format) question Further information is requested

Comments

@edyoshikun
Copy link
Contributor

edyoshikun commented Sep 11, 2023

The iohub Position.append_channel() function works great when the array to have a channel appended to shares the same dtype. In this case, we have some datasets stored as dtype=np.uint16 and when attempting to append a np.float32 dtype array, this proceeds without a warning.

The appropriate behaviour should be to raise a warning. In the case of having to change the whole dtype, I think it is probably easier to create a new zarr store, copy in the data, and then delete the old zarr store.

@ziw-liu
Copy link
Collaborator

ziw-liu commented Nov 2, 2023

iohub.ngff.Position.append_channel only takes in the new channel name and a flag to resize arrays. It does not take any data as input. Where do you think the warning should be triggered?

@ziw-liu ziw-liu added question Further information is requested NGFF OME-NGFF (OME-Zarr format) labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NGFF OME-NGFF (OME-Zarr format) question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants