Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the PNPM example test #492

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Nov 4, 2024

Currently the pnpm example test is failing. This seems to be due to an old version of pnpm being present on the machine (version 8 instead of version 9). I'm still a little unsure why this is the case...I would either expect pnpm not to be installed at all or for it to install the latest version as pnpm isn't packaged with node...maybe a cache hit?

After doing various testing ramykl#4 (sorry for the bad commit messages) it seems like the node orb doesn't install the package manager when using node/install-packages.

This will explicitly install the pnpm package manager through the node orb, which by default will install the latest version.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane jennifer-shehane changed the title [BUG] Fix the PNPM example test fix: Fix the PNPM example test Nov 4, 2024
@ramykl
Copy link
Contributor Author

ramykl commented Nov 4, 2024

@jennifer-shehane try again now. Sorry, the equal condition needed an and before it

@jennifer-shehane jennifer-shehane merged commit 5f7d64c into cypress-io:master Nov 5, 2024
7 of 8 checks passed
@jennifer-shehane
Copy link
Member

@MikeMcC399
Copy link
Collaborator

@jennifer-shehane

There is a workflow error in test-deploy.yml which causes a pnpm failure during deploy, although previously it passes.

As you noted in #468 (comment), this bug is preventing any new release of the Orb, like for the new Node documentation.

So if the broken master branch is to be fixed, either the pnpm example needs to be reverted or the workflow needs to be fixed.

Unfortunately the process for merging external contributions is risky (see #451) as errors are not found until it is too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants