Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak? #457

Closed
ctm opened this issue Oct 16, 2020 · 3 comments
Closed

memory leak? #457

ctm opened this issue Oct 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ctm
Copy link
Owner

ctm commented Oct 16, 2020

After about five and a half hours, both "uncle al" and "big mike" had client lockups that were solved by closing their table windows. At the time, both were connected to Zoom, so it wasn't a loss of internet connectivity. This was deep into the tourney and into the (fun) money, so I didn't want to stop things and ask them to look for errors in the JavaScript Console or to bring up some sort of memory profiling tool.

I'm not marking this as high priority, but it's probably something that needs to be looked at.

@ctm ctm added the bug Something isn't working label Oct 16, 2020
@ctm ctm self-assigned this Oct 16, 2020
@erb2000
Copy link

erb2000 commented Oct 16, 2020 via email

@ctm
Copy link
Owner Author

ctm commented Oct 16, 2020

@erb2000 Thanks. FWIW, I've been around the block before. See #112, for example.

@ctm
Copy link
Owner Author

ctm commented Jul 12, 2021

I'm not going to look at this in the near future. I'll be replacing the client "soon". Even if I weren't, this hasn't happened since and there have been a zillion upgrades in the meantime.

Eventually it makes sense to do performance testing and when it does I'll open a separate issue for it.

BTW, this is a super awesome article.

@ctm ctm closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants