Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught RuntimeError: unreachable #1508

Open
ctm opened this issue Nov 14, 2024 · 1 comment
Open

Uncaught RuntimeError: unreachable #1508

ctm opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon regression Something that formerly worked

Comments

@ctm
Copy link
Owner

ctm commented Nov 14, 2024

Use panic::set_hook to capture and eventually send to the server a backtrace.

Yesterday, a player got:

image

I'm pretty sure that's what shows up when the client panics. If so, we need to get a backtrace when the client panics and then try to send it to the server and if sending fails, try to log it to IndexDb and if logging it there fails, try to log it to LocalStorage. Then, the window should try to close itself so that the lobby will open a new, working window. We should also display some sort of "Hey, something went wrong, but we're on it" type message.

@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon regression Something that formerly worked labels Nov 14, 2024
@ctm ctm self-assigned this Nov 14, 2024
@ctm
Copy link
Owner Author

ctm commented Nov 14, 2024

Here's a Stack Overflow that mentions panic::set_hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon regression Something that formerly worked
Projects
None yet
Development

No branches or pull requests

1 participant