Player couldn't discard

[ctm]

Investigate why ODB Phat Mack🐺 couldn't discard in Pot-Limit Dramadugi.

He was moved into the table after the Dealing message was sent, but before the blinds were taken and my guess is that prevented his client from knowing what game he was playing:

 mb2=> select id, received_at at time zone 'America/Denver', message from public_table_messages where player_id is null and hand_id = 429406 order by received_at;
select id, received_at at time zone 'America/Denver', message from public_table_messages where player_id is null and hand_id = 429406 order by received_at;
    id    |          timezone          |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 message                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
----------+----------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 11656637 | 2024-11-03 18:48:17.970807 | {"Dealing": ["1000 2000 Pot-Limit Dramadugi", 1, "PotLimit", null, false, 429406, true, true, 0]}
 11656638 | 2024-11-03 18:48:19.4908   | {"MovedFrom": [17, 6135, "ODB Phat Mack🐺", null]}
 11656641 | 2024-11-03 18:48:19.979747 | "NoAnte"
 11656642 | 2024-11-03 18:48:19.98426  | {"Blinds": [11, 1000, false, "Small"]}
 11656643 | 2024-11-03 18:48:19.988649 | {"Blinds": [17, 2000, false, "Big"]}
 11656644 | 2024-11-03 18:48:19.99286  | {"BeginRound": [0, null, 2000, 0, false, 146]}
...
 11656687 | 2024-11-03 18:49:01.864631 | {"BeginRound": [2, [2, {"draw": {"Draw": [0, 3]}, "combination": "Without"}], 2000, 0, false, 148]}
 11656688 | 2024-11-03 18:49:01.87002  | {"Status": {"board": {"grid": null, "cards": {"cards": [{"Natural": {"rank": 9, "suit": "Club"}}, {"Natural": {"rank": 6, "suit": "Diamond"}}, {"Natural": {"rank": 7, "suit": "Club"}}]}}, "button": 1, "players": [{"id": 10, "seat": 1, "cards": {"cards": ["UnknownDown", "UnknownDown", "UnknownDown", "UnknownDown", "UnknownDown"]}, "chips": 24000, "action": 20000, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 11, "seat": 2, "cards": {"cards": []}, "chips": 66200, "action": 1000, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 17, "seat": 3, "cards": {"cards": ["UnknownDown", "UnknownDown", "UnknownDown", "UnknownDown", "UnknownDown"]}, "chips": 0, "action": 20000, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 9, "seat": 7, "cards": {"cards": []}, "chips": 9058, "action": 0, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}], "solo_ante": null, "action_type": "Drawing", "next_to_act": 3, "dormant_button": null, "cards_are_settable": false}}
 11656689 | 2024-11-03 18:49:01.876256 | {"RemindDraw": [20000, {"Draw": [0, 3]}, "2024-11-04T01:49:21.851553568Z", 17, 20]}
 11656700 | 2024-11-03 18:49:11.543678 | {"MoreTime": [17, 40, "2024-11-04T01:49:51.542006789Z", 40]}
 11656709 | 2024-11-03 18:49:26.843041 | {"MoreTime": [17, 40, "2024-11-04T01:50:06.841631998Z", 40]}
 11656809 | 2024-11-03 18:49:52.688129 | {"Chat": [17, "Cant disca"]}
 11656810 | 2024-11-03 18:49:55.748414 | {"MoreTime": [17, 40, "2024-11-04T01:50:35.746609930Z", 40]}
 11656833 | 2024-11-03 18:50:29.262759 | {"OnLevel": ["Level 10", [299999, "2024-11-04T01:55:29.261241883Z"], false, 9]}
 11656836 | 2024-11-03 18:50:35.748813 | {"Vacationed": 17}
 11656837 | 2024-11-03 18:50:35.75482  | {"Draws": [17, 0]}

I'm pretty sure that when a player is moved, that player doesn't get a replay of the messages that have occurred already, however the event in question was dramadugi, which is a single game tournament, so even though ODB came from table 6135, I would have thought the game would already be known.

There's a tiny chance that ODB was surprised by the fact that you can draw at most three cards in Dramadugi, whereas in other Dramaha variants you can draw four or five cards. I'll send email to ask him about this.

FWIW, I should have created this issue and followed up on it either on November 3rd or the following day, but I was pretty tired on November 3rd and forgot about it thereafter.

[ctm]

I've looked at the code and it's clear that we shouldn't allow a player to play in a hand if that player that was moved to a table after begin_hand_pre_shuffle has been called, unless we want to replay the Dealing message.

Fixing this is not trivial, in part because I haven't looked at this portion of the code in a long time. This bug has probably been with us for quite a while and has probably been triggered a few times here and there without anyone reporting it.