Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow linking multiple Discords to same Steam account. #49

Open
39ma opened this issue Apr 11, 2020 · 11 comments
Open

Disallow linking multiple Discords to same Steam account. #49

39ma opened this issue Apr 11, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@39ma
Copy link
Contributor

39ma commented Apr 11, 2020

Is your feature request related to a problem? Please describe.
I have found bug or feature that players can link any Discord to same SteamID multiple times. Just "discord" in DB "players" table is updating each time. Is it possible to disallow it? For example I banned in Discord 1 annoying person, he just created new Discord account and linked his old SteamID to new account.

Describe the solution you'd like
If people try to link already linked steam account there will be error

@cameronshinn
Copy link
Member

The instance you provided definitely seems like this is a "feature" that can be abused, so I'd call it a bug. I think we should fix this so what you experienced cannot happen again.

@cameronshinn cameronshinn added the bug Something isn't working label Apr 11, 2020
@B3none
Copy link
Member

B3none commented Apr 11, 2020

I know just the fix, we could make the steam id and discord id fields unique in the players table

@39ma
Copy link
Contributor Author

39ma commented Apr 11, 2020

I know just the fix, we could make the steam JD and discord id fields unique in the players table

I am not good at SQL, but it's not creating a new row. It's just updating existing raw. It's not changing "steam" field only "discord". If I'll make it unique will this restrict updating row?

@B3none
Copy link
Member

B3none commented Apr 11, 2020

Is it adding a steam ID multiple times?

@39ma
Copy link
Contributor Author

39ma commented Apr 11, 2020

Is it adding a steam ID multiple times?

No its not adding new rows, its just changing this field
image

@B3none
Copy link
Member

B3none commented Apr 11, 2020

I'll need to make a way to implement an is_banned column and check so that people who have a genuine reason to switch accounts still have the ability to do so.

@39ma
Copy link
Contributor Author

39ma commented Apr 11, 2020

I'll need to make a way to implement an is_banned column and check so that people who have a genuine reason to switch accounts still have the ability to do so.

Also it would be good to add to Discord bot some command like q!ban @user #time

@B3none
Copy link
Member

B3none commented Apr 11, 2020

I'll need to make a way to implement an is_banned column and check so that people who have a genuine reason to switch accounts still have the ability to do so.

Also it would be good to add to Discord bot some command like q!ban @user #time

Post this as a request on the discord bot

@cameronshinn
Copy link
Member

I'm working on implementing bans in the bot. I ran into this issue again, I guess it's still not resolved?

@B3none
Copy link
Member

B3none commented May 31, 2020

I'm working on implementing bans in the bot. I ran into this issue again, I guess it's still not resolved?

We need somewhere more accessible where we can test the data

@cameronshinn
Copy link
Member

Why do we need to know if the player is banned to prevent multiple accounts from being linked to their steam ID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants