Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling asvgf_temporal.comp on Ubuntu 18.04 #40

Open
lucastoro opened this issue Apr 30, 2019 · 1 comment
Open

Error compiling asvgf_temporal.comp on Ubuntu 18.04 #40

lucastoro opened this issue Apr 30, 2019 · 1 comment

Comments

@lucastoro
Copy link

Compiling with the following .config:

CONFIG_PNG=1
CONFIG_JPEG=1
CONFIG_SDL2=1
CONFIG_VKPT_RENDERER=1
CONFIG_VKPT_ENABLE_VALIDATION=0
CONFIG_NO_MD3=1
CONFIG_X11=y
CC=gcc

Leads to the following shader compilation error:

src/refresh/vkpt/shader/asvgf_temporal.comp
ERROR: src/refresh/vkpt/shader/asvgf_temporal.comp:231: 'format' : image formats must match 
ERROR: src/refresh/vkpt/shader/asvgf_temporal.comp:231: 'format' : image formats must match 
ERROR: src/refresh/vkpt/shader/asvgf_temporal.comp:233: '' : compilation terminated 
ERROR: 3 compilation errors.  No code generated.

In order to make the application run I "patched" glslangValidator so to skip the error, of course it's not a solution but the shader gets compiled and the q2vkpt runs.

--- a/glslang/MachineIndependent/ParseHelper.cpp
+++ b/glslang/MachineIndependent/ParseHelper.cpp
@@ -1166,2 +1166,2 @@ TIntermTyped* TParseContext::handleFunctionCall(const TSourceLoc& loc, TFunction
-                                                              argQualifier.layoutFormat != ElfNone))
-                            error(arguments->getLoc(), "image formats must match", "format", "");
+                                                              argQualifier.layoutFormat != ElfNone));
+                            //error(arguments->getLoc(), "image formats must match", "format", "");

q2vkpt: 0baa1a1fc33f98
glslang (pre-patch): 7.11.3204 (from here)
glslang: 86c72c9486a97 (from here)
Nvidia Driver: 430.09
OS: Ubuntu 18.04.2 x86_64 (4.15.0-48-generic)
GPU: GTX 1070
VK_NV_ray_tracing: extension revision 3

Thank you for your amazing work

@lucastoro lucastoro changed the title Error compiling asvgf_temporal.comp on Ubuntu 18.04 GTX1070 Error compiling asvgf_temporal.comp on Ubuntu 18.04 Apr 30, 2019
@scratlantis
Copy link

There seems to be some trouble with image formats when using images as function arguments.
See: KhronosGroup/GLSL#57
A solution that seems to work, is to make the entire function "temporal_filter(...)" in "asvgf_temporal.comp" into a macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants