-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS Detection #2
Comments
UAParser: userAgentData: Version: 5.3.18 |
UAParser: userAgentData: |
UAParser: userAgentData: Version: 10.13.6 |
UAParser: {"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:97.0) Gecko/20100101 Firefox/97.0","browser":{"name":"Firefox","version":"97.0","major":"97"},"engine":{"name":"Gecko","version":"97.0"},"os":{"name":"Mac OS","version":"10.13"},"device":{},"cpu":{}} userAgentData: |
UAParser: userAgentData: |
UAParser: userAgentData: Version: 10.0.0 |
UAParser: userAgentData: |
UAParser: userAgentData: Version: 10.0.0 |
UAParser: userAgentData: Version: 10.0.0 |
UAParser: userAgentData: |
UAParser: userAgentData: |
UAParser: userAgentData: Version: 12.2.1 |
userAgentData: UAParser: OS: |
Results UAParser: OS: |
Results highEntropyValues: UAParser: OS: |
@fbergmann After your fix, I have now get the normal Darvin version on Safari, and correct Intel version from Chrome. |
@shoops the new download site does not quite work for me on Safari and Firefox (arm, Monterey): it is fine on chrome though |
the ua parser strings currently are: safariuserAgentData:
undefined
UAParser:
{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Safari/605.1.15","browser":{"name":"Safari","version":"16.6","major":"16"},"engine":{"name":"WebKit","version":"605.1.15"},"os":{"name":"Mac OS","version":"10.15.7"},"device":{},"cpu":{}}
OS:
{"platform":"Mac OS","platformVersion":"10.15.7"} Firefoxhere it is even worse, as it is saying it would be an intel processor userAgentData:
undefined
UAParser:
{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:98.0) Gecko/20100101 Firefox/98.0","browser":{"name":"Firefox","version":"98.0","major":"98"},"engine":{"name":"Gecko","version":"98.0"},"os":{"name":"Mac OS","version":"10.15"},"device":{},"cpu":{}}
OS:
{"platform":"Mac OS","platformVersion":"10.15"} NOTE both are still confirming the platform to be macOS, so we should not see the source option for those. |
Debugging the code, on Firefox I find:
since the source package comes last it replaces (the also wrong old Mac version) and the source packages are offered. |
On firefox intel + arm versions loose points because of the platformVersion not matching. The source version does not loose points because the platform version for it is set to undefined. I think by default the old Mac version should get a lower version to begin with. then it would be fine to have it offered alongside arm / intel version. Source should only be offered as default in case something else went wrong. |
I've tried on another Mac (m2, arm), with a newer version of Chrome, and there detection of the OS also fails: Google ChromuserAgentData:
undefined
UAParser:
{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36","browser":{"name":"Chrome","version":"118.0.0.0","major":"118"},"engine":{"name":"Blink","version":"118.0.0.0"},"os":{"name":"Mac OS","version":"10.15.7"},"device":{},"cpu":{}}
OS:
{"platform":"Mac OS","platformVersion":"10.15.7"} |
I have fixed the scoring of source code. It will never outscore any installer. |
@shoops that did fix the issue for chrome, however on Safari I'm still offered the Darwin version (which won't work on the arm / intel processors) |
I just pushed a fix for version detection. |
@shoops now I get on arm only twice the intel one offered on chrome I now get the Darwin one. |
I allowed |
I fixed the reference vs copy problem you are seeing above. |
It is still not working on Chrome on the arm one (where it just suggests to download the ancient Darwin version). The issue is that when it reports arm, it does so as 'arm' not 'arm64', and it reports a platformVersion of 14.0.0. Here the detection result for the latest version: userAgentData:
{"brands":[{"brand":"Chromium","version":"118"},{"brand":"Google Chrome","version":"118"},{"brand":"Not=A?Brand","version":"99"}],"mobile":false,"platform":"macOS"}
highEntropyValues:
{"architecture":"arm","bitness":"64","brands":[{"brand":"Chromium","version":"118"},{"brand":"Google Chrome","version":"118"},{"brand":"Not=A?Brand","version":"99"}],"fullVersionList":[{"brand":"Chromium","version":"118.0.5993.117"},{"brand":"Google Chrome","version":"118.0.5993.117"},{"brand":"Not=A?Brand","version":"99.0.0.0"}],"mobile":false,"model":"","platform":"macOS","platformVersion":"14.0.0","uaFullVersion":"118.0.5993.117","wow64":false}
UAParser:
{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36","browser":{"name":"Chrome","version":"118.0.0.0","major":"118"},"engine":{"name":"Blink","version":"118.0.0.0"},"os":{"name":"Mac OS","version":"10.15.7"},"device":{},"cpu":{}}
OS:
{"platform":"macOS","architecture":"arm","bitness":"64","platformVersion":"14.0.0"} |
In order to enhance user download experience we would like to detect the OS and hardware the user is using. The intranet page link allows us to collect the currently provided information.
The text was updated successfully, but these errors were encountered: