Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails to load routes when opening a device from a route #532

Open
sshane opened this issue Jun 24, 2024 · 3 comments · May be fixed by #538
Open

fails to load routes when opening a device from a route #532

sshane opened this issue Jun 24, 2024 · 3 comments · May be fixed by #538
Labels
bug

Comments

@sshane
Copy link
Contributor

sshane commented Jun 24, 2024 •
edited
Loading

Inside a route, I just clicked on the device on the left.

From #501 @yaodingyd

failed.to.load.more.routes.mp4
@sshane sshane added the bug label Jun 24, 2024
@sshane sshane changed the title load more fails sometimes when opening a device from a route fails to load routes when opening a device from a route Jun 24, 2024
@yaodingyd
Copy link
Contributor

initial tests didn't really reproduce the issue. I think it might be another weird race condition. I'll spend some time first to get a consistent way to reproduce the bug

@yaodingyd
Copy link
Contributor

I still have trouble to reproduce, actually not able to get one yet. do you have any pointers?

@sshane
Copy link
Contributor Author

sshane commented Jul 1, 2024

Happens even on a new browser without extensions on the demo device.

  • Open a new tab and paste a link to a recent route
  • Click the device on the left
  • Doesn't load 2nd page
  • Refresh, it does
connect.not.load.device.repro.mp4

@yaodingyd yaodingyd linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use max of route's length and limit to fetch next routes yaodingyd/connect
2 participants
@yaodingyd @sshane