Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace duplicate device pairing code #418

Open
incognitojam opened this issue Aug 1, 2023 · 0 comments
Open

replace duplicate device pairing code #418

incognitojam opened this issue Aug 1, 2023 · 0 comments
Labels
cleanup

Comments

@incognitojam
Copy link
Collaborator

The UI elements for the successful pairing of a device is duplicated:

  • in explorer.jsx (pair tokens in URL only)
  • in the AddDevice component (pairing user QR scanner/camera)

https://github.com/commaai/connect/blob/master/src/components/Dashboard/AddDevice.jsx
https://github.com/commaai/connect/blob/master/src/components/explorer.jsx#L238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@incognitojam