Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table performance with 100,000 rows #1128

Closed
runrc opened this issue Aug 12, 2024 · 2 comments · Fixed by #1281
Closed

Table performance with 100,000 rows #1128

runrc opened this issue Aug 12, 2024 · 2 comments · Fixed by #1281
Labels
bug Something isn't working correctly confirmed This bug has been confirmed high priority This issue should be resolved quickly
Milestone

Comments

@runrc
Copy link

runrc commented Aug 12, 2024

Describe the feature

I have been experimenting with Cogent Core for our needs and have encountered possible performance issues which would be useful if addressed. Our requirements deal with large amounts of data.

For example, create a table with two fields and 100,000 rows and scroll the table, the redraw is laggy. Now, I know 100,000 rows is a lot, but just wondering, as the API stabilises - is now is the time to address and improve performance across all widgets?

An interim solution is to filter the data before adding to the table which is probably what we'll do, but I was interested in the thoughts of the team regarding profiling and improving performance and whether this is planned?

Relevant code

No response

@runrc runrc added the enhancement A new feature request label Aug 12, 2024
@kkoreilly
Copy link
Member

We have plans to optimize performance in general soon (#659), although we are currently focusing on more pressing feature additions and bug fixes (mostly WebGPU (#507) and GopherJS (#974) right now). However, independent of that, the table is designed to only configure and render the widgets currently being viewed, so the performance should be good even with 100,000 rows. However, when I tested it (using the same code as #1130), it does seem to be pretty laggy. We will look into that and see why it is not performing as it should.

@kkoreilly kkoreilly added bug Something isn't working correctly confirmed This bug has been confirmed and removed enhancement A new feature request labels Aug 12, 2024
@kkoreilly kkoreilly added this to the v0.4 milestone Aug 12, 2024
@kkoreilly kkoreilly added the high priority This issue should be resolved quickly label Oct 16, 2024
@kkoreilly
Copy link
Member

@runrc As of #1281, the table performance should be greatly improved; we tested it with 10,000,000 rows. If the issue persists or you have any more performance problems, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly confirmed This bug has been confirmed high priority This issue should be resolved quickly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants