Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in Header #118

Open
sylvainlg opened this issue May 3, 2023 · 5 comments
Open

Translation in Header #118

sylvainlg opened this issue May 3, 2023 · 5 comments

Comments

@sylvainlg
Copy link
Contributor

Hi

We need a translation dropdown in header for https://refugies.info/fr (we use this tool from dataesr implementation).
How can we implement this with codegouvfr/react-dsfr ?

Thanks

@garronej
Copy link
Collaborator

garronej commented May 3, 2023

Il sill preprod we have it as well: https://sill-preprod.lab.sspcloud.fr/

@garronej
Copy link
Collaborator

garronej commented May 3, 2023

https://github.com/codegouvfr/sill-web/blob/79849644649ad76b127b57759e4098570da83cc8/src/ui/shared/Header.tsx#L75-L79

https://github.com/codegouvfr/sill-web/blob/main/src/ui/shared/LanguageSelector.tsx

We have to reporte it to this repo but you can copy paste it in the meantime

@MustThinkOfAName
Copy link

@garronej
Hello!
After some quick testing I wanted to point out that apparently the locale selector works great in desktop mode but the drop-down menu is not triggered when clicked in mobile mode.
Thank you :)

@garronej
Copy link
Collaborator

garronej commented Feb 9, 2024

😢 Yes indeed

@MustThinkOfAName
Copy link

Hey guys!

I wondered if the implementation of the LanguageSelector component/fix on mobile was on your roadmap?

As for the last point, I gave it a quick glance and I believe the issue is that in your current implementation, the LanguageSelector component is treated as a quick access item.

Had the issue be simply inside the component, I'd have felt confident to try to propose an MR but as it seems to require modifying the Header component, I worry that my implementation wouldn't fit the architecture envisioned. (I could still propose something that you guys could later modify tho)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants