-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Counties] Add reordering options in counties list #221
Comments
Assign to me and I can take a look |
Can you add hacktoberfest to the label also? |
@aniri do you want every time someone drags and drops to send an update to the backend? I'm guessing every time they drag and drop we will save it. |
@aniri what happens if you filter the list and they change the order? Right now I disabled the drag and drop if the filter is on. If you filter, the index doesn't match the original order. However, the move to first when the filter is on should be able to work. |
@aniri do you have this icon? |
hey @Botosio
Also good idea with disabling the drag and drop when the filter is on! Thank you! |
yes, it should be a post without id for adding a county and a put with id for editing one. I'll add a backend issue to adjust these ;) thanks! |
@aniri sounds good. I made the global change in this next pr to change the word "Country" to "County".... I might have been the culprit in that. |
@aniri we need a delete also, for county |
@Botosio thanks for the suggestion! I added a backend issue for all the mentioned changes :D |
depends on code4romania/monitorizare-vot#388 |
Depends on #215
Add the option for setting a county as first in the list.
Add the possibility of reordering the counties by drag and dropping the items from the counties table.
Please suggest backend endpoints if needed.
UI available here: https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=754%3A0
The text was updated successfully, but these errors were encountered: