Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Counties] Add reordering options in counties list #221

Open
aniri opened this issue Feb 22, 2020 · 12 comments · May be fixed by #361
Open

[Counties] Add reordering options in counties list #221

aniri opened this issue Feb 22, 2020 · 12 comments · May be fixed by #361

Comments

@aniri
Copy link
Member

aniri commented Feb 22, 2020

Depends on #215

Add the option for setting a county as first in the list.

Add the possibility of reordering the counties by drag and dropping the items from the counties table.

Please suggest backend endpoints if needed.

UI available here: https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=754%3A0

@aniri aniri changed the title [Counties] Add drag and drop option to counties list [Not ready for dev][Counties] Add drag and drop option to counties list Feb 22, 2020
@aniri aniri changed the title [Not ready for dev][Counties] Add drag and drop option to counties list [Counties] Add drag and drop option to counties list Oct 23, 2021
@aniri aniri changed the title [Counties] Add drag and drop option to counties list [Counties] Add reordering options in counties list Oct 23, 2021
@Botosio
Copy link
Contributor

Botosio commented Oct 23, 2021

Assign to me and I can take a look

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

Can you add hacktoberfest to the label also?

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

@aniri do you want every time someone drags and drops to send an update to the backend?
Do we need a save button?

I'm guessing every time they drag and drop we will save it.

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

@aniri what happens if you filter the list and they change the order?

Right now I disabled the drag and drop if the filter is on.

If you filter, the index doesn't match the original order. However, the move to first when the filter is on should be able to work.

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

@aniri do you have this icon?
image

@Botosio Botosio linked a pull request Oct 25, 2021 that will close this issue
@aniri
Copy link
Member Author

aniri commented Oct 26, 2021

hey @Botosio

I'm guessing every time they drag and drop we will save it.
Yep, sounds good!

Also good idea with disabling the drag and drop when the filter is on!

Here's the icon :D
double up

Thank you!

@Botosio
Copy link
Contributor

Botosio commented Nov 3, 2021

Should there be a post without the ID for new Counties?

image

@aniri
Copy link
Member Author

aniri commented Nov 3, 2021

yes, it should be a post without id for adding a county and a put with id for editing one.

I'll add a backend issue to adjust these ;) thanks!

@Botosio
Copy link
Contributor

Botosio commented Nov 5, 2021

@aniri sounds good. I made the global change in this next pr to change the word "Country" to "County".... I might have been the culprit in that.

@Botosio
Copy link
Contributor

Botosio commented Nov 5, 2021

@aniri we need a delete also, for county

@aniri
Copy link
Member Author

aniri commented Nov 6, 2021

@Botosio thanks for the suggestion! I added a backend issue for all the mentioned changes :D

@aniri
Copy link
Member Author

aniri commented Oct 3, 2022

depends on code4romania/monitorizare-vot#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants