Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] [BACKLOG] Prepare playground page with all new UI elements #209

Open
aniri opened this issue Feb 18, 2020 · 7 comments
Open

[UI] [BACKLOG] Prepare playground page with all new UI elements #209

aniri opened this issue Feb 18, 2020 · 7 comments

Comments

@aniri
Copy link
Member

aniri commented Feb 18, 2020

We are starting migrating to a prettier UI for the app.

It would be great to have a demo page will all new input elements and all the setup for their behaviour (checkboxes, text areas, buttons, dropdowns, table, paginated table). This way we can easily re-use them when redesigning the app and keep a consistent style.

The styleguide is available here: https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-(Copy)?node-id=816%3A217

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Sep 26, 2020

@aniri how about a Storybook integration?

It should be as easy as npx sb init
Already installing project dependencies.

@aniri
Copy link
Member Author

aniri commented Sep 26, 2020

@aniri how about a Storybook integration?

@iamandrewluca sounds good!

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Sep 26, 2020

Encountered some problems. We need to move tsconfig.json file one level up in the project folder.
I took a look at project history, and it seems this project was started with angular@2, and upgraded till angular@9
Folder structure may not be exactly as it is default now, and storybook cannot be initialized correctly.

I made the fix with moving tsconfig file, I'll make a PR. (Also no more warnings in console)

I would suggest in the future to create a brand new Angular app, and overlay it on top of current app. I did this once in a https://github.com/code4moldova/voluntar-web repository.

@idormenco
Copy link
Member

@iamandrewluca hi , i managed to install storybook on this app (it took a little bit of handling but it works) please see this pr/ branch you can contribute there as well

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Oct 5, 2020

Ok, then I'll close my PR's in favor of this

@idormenco
Copy link
Member

@iamandrewluca we should discuss on code4ro slack on what we have to do further and sync our efforts.

@aniri
Copy link
Member Author

aniri commented Oct 6, 2020

hey @iamandrewluca @idormenco thanks for your help with this! We'll postpone this part for now and focus first on updating the UI and then on extracting reusable components 😃

@aniri aniri changed the title [UI] Prepare playground page with all new UI elements [UI] [BACKLOG] Prepare playground page with all new UI elements Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants