Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies between rulesets? #339

Open
rulatir opened this issue Jul 24, 2024 · 0 comments
Open

Dependencies between rulesets? #339

rulatir opened this issue Jul 24, 2024 · 0 comments

Comments

@rulatir
Copy link

rulatir commented Jul 24, 2024

Code in the DefaultRuleProvider class clearly shows that the ukrainian ruleset requires russian to also be applied - otherwise only Ukrainian-specific Cyrillic letters are transliterated, and unaccented Cyrillic letters are not. This is not the case with the bulgarian ruleset that handles the Bulgarian variant of the Cyryllic alphabet in its entirety.

I believe the basic Cyrillic transliteration should be inlined in the ukrainian ruleset, just like with bulgarian. Even if applying russian and ukrainian rulesets will have the exact same effect, treating Ukrainian as if it were a variety of Russian feels wrong in 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant