Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos terraform shell Prompt Regression #779

Closed
RoseSecurity opened this issue Nov 13, 2024 · 3 comments · Fixed by #786
Closed

Atmos terraform shell Prompt Regression #779

RoseSecurity opened this issue Nov 13, 2024 · 3 comments · Fixed by #786
Labels
bug 🐛 An issue with the system

Comments

@RoseSecurity
Copy link
Member

RoseSecurity commented Nov 13, 2024

Describe the Bug

After upgrading from Atmos 1.98.0 to 1.105.0, atmos terraform shell inside of Geodesic does not behavior as expected, producing the following output:

 √ . [devops] (HOST) infra ⨠ atmos terraform shell <component>-s <stack>

Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.
Initializing modules...

Initializing provider plugins...
- terraform.io/builtin/terraform is built in to Terraform

Terraform has been successfully initialized!

root@e36b6d3f0c3a:/localhost/infra/components/terraform/eks/cluster#

Expected Behavior

The prompt should be maintained as follows:

Terraform has been successfully initialized!
 √ : [devops] (HOST) eks/cluster ⨠ 

Steps to Reproduce

Version:

 √ . [devops] (HOST) infra ⨠ atmos version

👽 Atmos 1.105.0 on linux/arm64

Command:

atmos terraform shell <component> -s <stack>

Screenshots

No response

Environment

No response

Additional Context

No response

@RoseSecurity RoseSecurity added the bug 🐛 An issue with the system label Nov 13, 2024
@osterman
Copy link
Member

Relates to #761

@osterman
Copy link
Member

We will get this fixed ASAP. Problem we tried to solve is for non geodesic users the sub shell behavior is not as polished. I think the quick fix is to make this configurable and disabled by default until we have a better working compromise.

@RoseSecurity
Copy link
Member Author

We will get this fixed ASAP. Problem we tried to solve is for non geodesic users the sub shell behavior is not as polished. I think the quick fix is to make this configurable and disabled by default until we have a better working compromise.

I am a big fan of the feature, and haven't read the code for it yet, but if this toggles a environment variable, maybe it could also be accomplished at the Geodesic layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants