Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf revision - see details on a specific app revision #1959

Open
danfein opened this issue Jun 22, 2020 · 7 comments
Open

cf revision - see details on a specific app revision #1959

danfein opened this issue Jun 22, 2020 · 7 comments
Assignees
Milestone

Comments

@danfein
Copy link

danfein commented Jun 22, 2020

Please provide details on the following items. Failure to do so may result in deletion of your feature request.

What's the user value of this feature request?
There is a ‘cf revisions’ command to get a list of past revisions with some information about the revision. There are details about the revision that are left out of the table that would be helpful to see in some cases.

Who is the functionality for?
Application developers and operators making decisions about revisions to rollback to
Triage/troubleshooting cases where folks want to see what changes have been made to an app

How often will this functionality be used by the user?
How often will they use this feature?

Who else is affected by the change?
This is a new command and does not introduce breaking changes

Is your feature request related to a problem? Please describe.
Currently detailed information about revisions can be found, but thru different api endpoints, it is not possible to see/evaluate revision details in a single view.

Describe the solution you'd like
A cli command to specify an app and revision that returns details about that revision

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
We considered adding more columns in the revisions command, but much of what this command tells you seems to fit into different use-cases than the 'show me my revisions so I can choose one to rollback to quickly'

Additional context
Add any other context or screenshots about the feature request here.

$ cf revision dora -revision 4
Showing revision 4 for app dora in org abby / space dodo as admin...

revision  status            description            deployable   revision GUID:                        created on
4         deployed(active)  new droplet deployed   true         585bc3c1-3743-497d-88b0-403ad6b56d16  2020-03-01T01:33:58Z

Revision Labels:
environment: production
tmc.cloud.vmware.com/creator:myvmware306_vmware-hol.com
type: data

Revision Annotations:
cody: "app dev", "415-300-3000", "data services"

----------

Droplet GUID:
585bc3c1-3743-497d-88b0-403ad6b56d16

Application Environment Variables:
potato: fried
karen: o
ASPNETCORE_ENVIRONMENT: Development
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/173456870

The labels on this github issue will be updated when the story is started.

@danfein
Copy link
Author

danfein commented Jun 22, 2020

@heyjcollins @pivotalrobbie FYI

@reidmit
Copy link
Contributor

reidmit commented Jun 22, 2020

I think this command makes sense and would be useful! A couple of stylistic notes:

Since this is a "summary" (aka "view single resource") command, I'm thinking it should follow the patterns laid out here. Most notably, that means it should use the vertical, key-value pair style of table, rather than the horizontal style (which is for viewing multiple resources at once).

Also, if the revision is required (and it seems like it is), can we make it a positional argument rather than a flag? e.g. cf revision dora 4. This is the pattern laid out here – optional inputs should be flags, and required inputs should be positional arguments.

@heyjcollins heyjcollins added this to the 7.1.0 milestone Jul 28, 2020
@heyjcollins
Copy link
Contributor

for cf revision appname - return details for the current active/deployed revision of appname
for cf revision appname --revision 2 - return details for revision #2

this leaves flexibility for us to use a different unique identifier in the future should we decide to do so (revision GUID).

@pauldavidgilligan
Copy link

do you plan also to include the active status information? For example in the UI we can see Deployed (Active). This would be useful information for continuous deployments.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed.

@a-b
Copy link
Member

a-b commented Oct 1, 2024

Thank you for your patience regarding the issue you reported. We will be reviewing your ticket with our product team to assess its impact and potential next steps. Once we have their feedback, we will update you accordingly.

If you have any further questions or additional information to share in the meantime, please feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants