Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawler incorrectly adds Microsoft Copyright to NuGet Packages #520

Open
seantleonard opened this issue Apr 12, 2023 · 1 comment
Open

Comments

@seantleonard
Copy link

Suggestion: The ClearlyDefined crawler should not attempt to discover copyright information from the aka.ms/deprecateLicenseUrl link stamped into the deprecated licenseUrl NuGet package metadata field.

Background:
When a NuGet package's build configuration or nuget.config does not explicitly set a value for the deprecated NuGet package metadata field licenseUrlper NuSpec Referece, the field is populated with the link (https://aka.ms/deprecateLicenseUrl ) by default. In the past, this link may have pointed to a Microsoft Docs page with a deprecation notice at one point in time. The linked doc page doesn't have the deprecation notice anymore and should be updated.

This causes an issue where ClearlyDefined crawler attempts to gather license data for a package and thinks that following the aka link in the deprecated field will provide copyright information for the package. This results in the crawler scraping a Microsoft copyright from the Microsoft docs page and stamping it into a NuGet package. This incorrectly attributes a packages copyright to Microsoft which to me seems erroneous as Microsoft doesn't have copyright over all NuGet packages.

In my opinion, expecting package authors to manually set that deprecated field to replace the URL https://aka.ms/deprecateLicenseUrl​ is not a viable solution because setting the licenseUrl​ property in the per package .nuspec​ config file used for NuGet package creation will result in a package build warning NuGet Error NU5125 | Microsoft Learn.

This isn't a one package's specific problem as seen when Google searching that aka.ms link and observing many packages' metadata files containing that URL as default when publishing packages to NuGet.

@seantleonard
Copy link
Author

Possible follow-up on #213

@seantleonard seantleonard changed the title Crawler incorrectly adds Microsoft Copyright to Nuget Packages Crawler incorrectly adds Microsoft Copyright to NuGet Packages Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant