New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Introduce a coding style + tool #49

Open

Kocal opened this issue Nov 29, 2022 · 0 comments

Kocal commented Nov 29, 2022 •

edited

Loading

Hi,

Using a coding style in an open-source projet is important, it allows code wrote by many people to stay consistent.

I don't know what PHP coding style you use at CKEditor, but if you don't, then using PSR-12 can be a nice start.

Using Easy Coding Standard is a really nice tool that combines both PHP-CS-Fixer and PHP_CodeSniffer, and provides some configuration sets.

For example, on my fork, I've used PSR12, PHPUnit, and clean code sets: https://github.com/Kocal/ckfinder-symfony-bundle/blob/main/ecs.php#L20-L24

WDYT?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment