From d19fc8418f89078bdadf60604df3d913c60df6f7 Mon Sep 17 00:00:00 2001
From: Mateusz Baginski <cziken58@gmail.com>
Date: Fri, 16 Aug 2024 07:03:31 +0200
Subject: [PATCH] Simplify composable even more

---
 demos/editor-cdn/Editor.vue | 13 ++++++-------
 src/useCKEditorCloud.ts     |  8 +++++---
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/demos/editor-cdn/Editor.vue b/demos/editor-cdn/Editor.vue
index f660cf9..c995826 100644
--- a/demos/editor-cdn/Editor.vue
+++ b/demos/editor-cdn/Editor.vue
@@ -37,7 +37,7 @@
 </template>
 
 <script setup lang="ts">
-import { ref, reactive, watchEffect } from 'vue';
+import { ref, reactive, computed } from 'vue';
 
 import type * as CKEditor5 from 'https://cdn.ckeditor.com/typings/ckeditor5.d.ts';
 import { useCKEditorCloud } from '../../src/plugin.js';
@@ -54,17 +54,14 @@ const config = reactive( {
 	toolbar: [ 'heading', '|', 'bold', 'italic' ]
 } );
 
-const EditorConstructor = ref<typeof CKEditor5.ClassicEditor | null>( null );
-const editorInstance = ref<CKEditor5.ClassicEditor | null>( null );
-
-watchEffect( () => {
+const EditorConstructor = computed<typeof CKEditor5.ClassicEditor | null>( () => {
 	if ( !cloud.data.value ) {
-		return;
+		return null;
 	}
 
 	const { ClassicEditor, Paragraph, Essentials, Heading, Bold, Italic } = cloud.data.value.CKEditor;
 
-	EditorConstructor.value = class TestEditor extends ClassicEditor {
+	return class TestEditor extends ClassicEditor {
 		static builtinPlugins = [
 			Essentials,
 			Paragraph,
@@ -75,6 +72,8 @@ watchEffect( () => {
 	};
 } );
 
+const editorInstance = ref<CKEditor5.ClassicEditor | null>( null );
+
 // Methods
 function setEditorData() {
 	data.value = editorInstance.value?.getData() ?? '';
diff --git a/src/useCKEditorCloud.ts b/src/useCKEditorCloud.ts
index 3550511..de0fd80 100644
--- a/src/useCKEditorCloud.ts
+++ b/src/useCKEditorCloud.ts
@@ -3,7 +3,7 @@
  * For licensing, see LICENSE.md.
  */
 
-import { toValue, type ComputedRef, type MaybeRefOrGetter } from 'vue';
+import { toValue, type MaybeRefOrGetter } from 'vue';
 import { useAsync, type AsyncComposableResult } from './composables/useAsync';
 
 import {
@@ -35,9 +35,11 @@ import {
  * }
  */
 export default function useCKEditorCloud<A extends CKExternalPluginsMap>(
-	config: MaybeRefOrGetter<CKEditorCloudConfig<A>> | ComputedRef<CKEditorCloudConfig<A>>
+	config: MaybeRefOrGetter<CKEditorCloudConfig<A>>
 ): AsyncComposableResult<CKEditorCloudResult<A>> {
 	return useAsync(
-		(): Promise<CKEditorCloudResult<A>> => loadCKEditorCloud( toValue( config ) )
+		(): Promise<CKEditorCloudResult<A>> => loadCKEditorCloud(
+			toValue( config )
+		)
 	);
 }