Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection is being displayed incorrectly around the linkHref nodes #88

Open
pomek opened this issue Jul 9, 2020 · 3 comments
Open

Selection is being displayed incorrectly around the linkHref nodes #88

pomek opened this issue Jul 9, 2020 · 3 comments
Labels
domain:dx squad:core Issue to be handled by the Core team. type:improvement

Comments

@pomek
Copy link
Member

pomek commented Jul 9, 2020

Something wrong happens around links. Check out screenshots attached in the issues listed below:

@pomek pomek added the type:bug label Jul 9, 2020
@oleq
Copy link
Member

oleq commented Jul 9, 2020

Can you write this as expected vs actual? I'm having a hard time figuring out what the problem is.

@pomek
Copy link
Member Author

pomek commented Jul 9, 2020

In both cases, editor's selection is at the end of a link. The inspector shows it outside, in the next node.

@oleq
Copy link
Member

oleq commented Jul 9, 2020

There's no such thing as a selection in the textnode in the model. <$text linkHref>foo[]</$text> and <$text linkHref>foo</$text>[] are one and the same position. So from this perspective, the inspector does not lie.

What could be improved, though, is the normalization of the caret rendering because I admit this could be annoying in certain situations.

@jodator jodator added this to the nice-to-have milestone Aug 26, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:ux labels Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx squad:core Issue to be handled by the Core team. type:improvement
Projects
None yet
Development

No branches or pull requests

4 participants