Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model attribute value is not rendered correctly when an object #110

Open
oleq opened this issue Jan 28, 2021 · 2 comments
Open

Model attribute value is not rendered correctly when an object #110

oleq opened this issue Jan 28, 2021 · 2 comments

Comments

@oleq
Copy link
Member

oleq commented Jan 28, 2021

@oleq oleq added the type:bug label Jan 28, 2021
@pomek pomek added squad:platform Issue to be handled by the Platform team. and removed squad:dx labels May 28, 2021
@pomek pomek modified the milestones: iteration 44, backlog May 31, 2021
@Reinmar Reinmar modified the milestones: backlog, nice-to-have Aug 4, 2021
@pomek
Copy link
Member

pomek commented Aug 16, 2021

Consider increasing value from 1 to 2 here:

const stringified = javascriptStringify( value, stringifySingleToDoubleQuotesReplacer, null, {
maxDepth: 1
} );

image

@oleq
Copy link
Member Author

oleq commented Aug 24, 2021

Just keep in mind that:

  • IIRC this will also affect the selection/node (object) inspector on the right,
  • some attributes have huge nested structures, and printing two levels meant printing really insane stuff, especially, if there was a reference to model/editor/document (any large structure, really). Mentions suffered from this, and although it was fixed at some point it's hard to predict what's in there.
  • #98: The inspector should not throw when attributes are objects with circular references #102

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@pomek pomek removed the squad:platform Issue to be handled by the Platform team. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants