Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json incorrect and wrong Chrome path #1

Open
dublx opened this issue Jun 30, 2015 · 4 comments
Open

manifest.json incorrect and wrong Chrome path #1

dublx opened this issue Jun 30, 2015 · 4 comments

Comments

@dublx
Copy link

dublx commented Jun 30, 2015

When following the website instructions, after the gen command I got a incorrect manifest.json, it was missing the very last curly brace.
Also, for the Mac Chrome link that worked for me was:
CHROME='/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome'

Based in commit 855fdf2.

@No9
Copy link
Contributor

No9 commented Jun 30, 2015

Thanks for having a look @dublx !
This was super helpful.

As well as the manifest problem
https://github.com/chromiumify/chromiumify/blob/master/templates/manifest.json#L27

this also highlighted a missing test
https://github.com/chromiumify/chromiumify/blob/master/test/run.js#L6

Which in turn raised this missing option on gen
https://github.com/chromiumify/chromiumify/blob/master/index.js#L23

All three are now committed and published to npm. 2.1.1

If you get a chance to test and close that would be really appreciated.

@No9
Copy link
Contributor

No9 commented Jun 30, 2015

@dublx Just realized you mention wrong chrome path in the issue header.

The path you gave is the same as I had in the runner for darwin.
Can you paste the error you are seeing when the app tries to run in here please so I can investigate further.

@No9
Copy link
Contributor

No9 commented Jun 30, 2015

Ah think it needs a double escape for the \

@No9
Copy link
Contributor

No9 commented Jun 30, 2015

Yup that was it finally got temp access to a mac to debug
See https://github.com/chromiumify/chromiumify/blob/master/index.js#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants