Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network fetching policy hits rate limits #10

Open
chrislloyd opened this issue Mar 23, 2020 · 1 comment
Open

Network fetching policy hits rate limits #10

chrislloyd opened this issue Mar 23, 2020 · 1 comment

Comments

@chrislloyd
Copy link
Contributor

The extension looks like it's extremely efficient at fetching the user information cache on startup. However, because it fetches so quickly, it can block other phabricator operations from happening from the same machine. This is what happens when I try and arc diff as the extension is fetching new users:

Screen Shot 2020-03-23 at 11 09 47 AM

@cdanis
Copy link

cdanis commented Dec 18, 2020

We at the Wikimedia Foundation have a relatively sizable Phabricator installation with over 22,000 users.

Unfortunately we've had a few issues created for all users by just a couple users of this extension, and for now we don't have a great choice aside from ratelimiting its user-agent string at our CDN edge.

From the extension's POV it might make sense to warn the user and 'give up' on fetching 100% of users after you've fetched N users already (a few hundred?), and then disable autocompletion for users.

wmfgerrit pushed a commit to wikimedia/operations-puppet that referenced this issue Jan 11, 2021
The vscode-phabricator plugin is known to fetch users too agressivly and
causes issues with phabricator:
 * christianvuerings/vscode-phabricator#10
As such add a ratelimit and alert users

Bug: T270482
Bug: T271528
Change-Id: I42a6270240512ec7a960da83e16b2129a55c99e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants