Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mousetrap belongs in bower.json dependencies, not devDependencies #265

Open
erikdonohoo opened this issue Mar 23, 2017 · 1 comment
Open

mousetrap belongs in bower.json dependencies, not devDependencies #265

erikdonohoo opened this issue Mar 23, 2017 · 1 comment

Comments

@erikdonohoo
Copy link

If mousetrap is not in dependencies, then each bower user of this library is required to have their own explicit dependency on mousetrap. Please move this from devDependencies to dependencies.
@erikdonohoo erikdonohoo mentioned this issue Mar 23, 2017
Open
@aramando
Copy link

aramando commented Mar 24, 2017 •
edited
Loading

The distribution builds of angular-hotkeys in build/ already contain the Mousetrap library, so users have no need of a separate dependency. Only developers working on src/angular-hotkeys.js need the separate Mousetrap library, so it is in fact a devDependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aramando @erikdonohoo