Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about C++ exceptions #241

Open
n0F4x opened this issue Dec 25, 2023 · 1 comment
Open

Add more information about C++ exceptions #241

n0F4x opened this issue Dec 25, 2023 · 1 comment

Comments

@n0F4x
Copy link
Contributor

n0F4x commented Dec 25, 2023

I am struggling to find out the kind of exceptions each function can throw if any. (Maybe I am just a noobie, so excuse me for that.)
I would like to raise this issue to write documentation about the exception policy of the library, which right now, it lacks. And also, to mark functions that do not throw with noexcept.

@charles-lunarg
Copy link
Owner

This library doesn't throw any exceptions of its own, but does use standard library types (std::vector, std::string) which are liable to throw.

I could mark stuff as noexcept, and probably be fine but I'm not sure adding noexcept adds much. I'm not too worried about performance since this is an initialization library rather than runtime.

I certainly could add this disclaimer to the readme or other documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants