Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View tomogram button in Tomogram table (on single run page) should not show if it's greyed out #1334

Open
junxini opened this issue Nov 8, 2024 · 3 comments
Labels
bug Something isn't working severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo)

Comments

@junxini
Copy link
Contributor

junxini commented Nov 8, 2024

Describe the bug
where visualization in NG isn't available, the view tomogram button should not be visible. currently, it's showing as visible and greyed out.

To Reproduce
Steps to reproduce the behavior:

  1. Go to single run page --> tomogram tab --> view tomogram button
    example URL: https://cryoetdataportal.czscience.com/runs/16463?table-tab=Tomograms

Screenshots
Screenshot 2024-11-07 at 5 57 17 PM

Additional context
Figma designs: link here

@junxini junxini added the bug Something isn't working label Nov 8, 2024
@junxini
Copy link
Contributor Author

junxini commented Nov 8, 2024

@Janeece when you're back, will you sanity check to make sure this bug is accurate?

@Janeece
Copy link
Collaborator

Janeece commented Nov 13, 2024

@junxini you're correct.

  1. Only the "viz default" tomogram would show the view button. The rest should show no view button at all.
  2. Table ordering seems correct, but needs portal standard tomogram to confirm. Button will not always be first. Order is determined by the "portal standard"/"author-submitted" tags + the tomo IDs (largest to smallest), "viz default" doesn't impact ordering (ordering spec here)
    • From example, view button is last because the "viz default" tomogram has the smallest (oldest) ID.

@junxini
Copy link
Contributor Author

junxini commented Nov 13, 2024

Thanks Janeece for double checking and additional context on the sorting! i'll bring it into backlog refinement this week

@manasaV3 manasaV3 added the severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo)
Projects
None yet
Development

No branches or pull requests

3 participants