Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Package.resolved version 3 #1059

Open
ed-irl opened this issue May 5, 2024 · 0 comments
Open

Support for Package.resolved version 3 #1059

ed-irl opened this issue May 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ed-irl
Copy link

ed-irl commented May 5, 2024

A new Package.resolved format was seemingly released in xcode 15.3. The format seems to be the same for the purposes of the pins in my repo, which are all remote. I was able to resolve the issue by adding case 2, 3: in pin.go.

Since this type of upgrade happens more or less silently, it might be worth revising the error message in this file to be more informational, eg. instead of "unrecognized version %d for resolved package JSON" it could be "A new 'Package.resolved' format version %d was detected. This may happen when a new xcode version is released. Please report the new version at https://github.com/cgrindel/rules_swift_package_manager/issues. In the meantime, you can resolve this problem by using git_override to patch pin.go and the associated pin_store*.go files."

@cgrindel cgrindel added the bug Something isn't working label May 5, 2024
jpsim added a commit that referenced this issue Jun 17, 2024
cgrindel pushed a commit that referenced this issue Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants