Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X in vdW complex gets typed as Xv (vacant) not Xo (occupied) #58

Open
mazeau opened this issue Feb 12, 2019 · 3 comments
Open

X in vdW complex gets typed as Xv (vacant) not Xo (occupied) #58

mazeau opened this issue Feb 12, 2019 · 3 comments

Comments

@mazeau
Copy link

mazeau commented Feb 12, 2019

To get all the database tests to pass, we had to change the adj list for surface dissociation vdW from Xo to X because making a sample molecule would always return Xv and the test would fail.

@rwest
Copy link
Collaborator

rwest commented Apr 1, 2019

Probably van-der-Waals sites should be not vacant. They should be occupied.

We're not quite sure what impact it has.
Maybe other reactions that depend on the concentration of vacant sites would be too fast if we over-count vacant sites.

So this should be fixed

@alongd
Copy link

alongd commented Apr 25, 2019

I think we should add in atomType actions Xo to Xo.breakBond, to have:
atomTypes['Xo' ].setActions(incrementBond=['Xo'], decrementBond=['Xo'], formBond=['Xo'], breakBond=['Xv', 'Xo'],

@alongd
Copy link

alongd commented Apr 25, 2019

I just learned that a VDW-bonded X site has atomType Xv (not Xo).
I'm taking back the previous suggestion, and changing the set action of Xo so it's not allowed to form bonds:
atomTypes['Xo' ].setActions(incrementBond=['Xo'], decrementBond=['Xo'], formBond=[], breakBond=['Xv'],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants