You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To get all the database tests to pass, we had to change the adj list for surface dissociation vdW from Xo to X because making a sample molecule would always return Xv and the test would fail.
The text was updated successfully, but these errors were encountered:
Probably van-der-Waals sites should be not vacant. They should be occupied.
We're not quite sure what impact it has.
Maybe other reactions that depend on the concentration of vacant sites would be too fast if we over-count vacant sites.
I think we should add in atomType actions Xo to Xo.breakBond, to have: atomTypes['Xo' ].setActions(incrementBond=['Xo'], decrementBond=['Xo'], formBond=['Xo'], breakBond=['Xv', 'Xo'],
I just learned that a VDW-bonded X site has atomType Xv (not Xo).
I'm taking back the previous suggestion, and changing the set action of Xo so it's not allowed to form bonds: atomTypes['Xo' ].setActions(incrementBond=['Xo'], decrementBond=['Xo'], formBond=[], breakBond=['Xv'],
To get all the database tests to pass, we had to change the adj list for surface dissociation vdW from Xo to X because making a sample molecule would always return Xv and the test would fail.
The text was updated successfully, but these errors were encountered: