Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still some issues with mid-level group definitions #41

Open
rwest opened this issue Oct 9, 2018 · 0 comments
Open

Still some issues with mid-level group definitions #41

rwest opened this issue Oct 9, 2018 · 0 comments

Comments

@rwest
Copy link
Collaborator

rwest commented Oct 9, 2018

This commit rwest/RMG-database@aa5690a shows the groups we were working on. Emily added something to the group file, so that it'd be usable, and then we did some work editing them, but there are still some questions in there to be addressed.

We want the group definitions to be more general than their children, but more specific than their parent, and make chemical sense. If we can't achieve all three, then perhaps we should remove a level from the tree. Please could @kblondal take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant