Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete GH_USER cookie #70

Open
VallariAg opened this issue Sep 13, 2024 · 4 comments
Open

Delete GH_USER cookie #70

VallariAg opened this issue Sep 13, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@VallariAg
Copy link
Member

Even after we logout from pulpito-ng, the GH_USER cookie isn't deleted.

It would be nice to delete this before sending RedirectResponse in /logout endpoint on teuthology-api.

Example (chrome):

image
@VallariAg VallariAg added the good first issue Good for newcomers label Sep 13, 2024
@VallariAg
Copy link
Member Author

Instead of using cookies, we can instead use react's UseContext to call useSession hook in pulpito-ng and store user data in context. This is a better solution because cookies can have stale data but UseContext would have latest data from teuthology-api. And all components can use that data.

@VallariAg VallariAg changed the title Delete GH_USER cookie on logout Delete GH_USER cookie Sep 14, 2024
@AyishikD
Copy link

@VallariAg Can I solve this issue too?

@VallariAg
Copy link
Member Author

@AyishikD I need to have a discussion with other members about the two approaches and confirm how to proceed. I will update here what we decide to do.

@AyishikD
Copy link

@AyishikD I need to have a discussion with other members about the two approaches and confirm how to proceed. I will update here what we decide to do.

Sure thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants