Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to request a block via its hash #1395

Open
evan-forbes opened this issue Jun 17, 2024 · 3 comments
Open

Add ability to request a block via its hash #1395

evan-forbes opened this issue Jun 17, 2024 · 3 comments

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Jun 17, 2024

We should add the ability to query a block by its hash via grpc. Currently, we can only easily by its height.

To close this issues, introduce a new grpc method that uses a new index hash: height, to first look up the height and then look up the block based on its height.

ref celestiaorg/celestia-app#3421 (comment)

@cmwaters
Copy link
Contributor

I don't think this issue belongs in this repo. We discussed having the gRPC server as a service in celestia-app or at least extending the existing interface in our cosmos-sdk although I would prefer to keep this in celestia-app

@Eoous
Copy link
Contributor

Eoous commented Jul 26, 2024

I think it's no necessary and difficult to have gRPC service in celestia-app or cosmos-sdk.

Looks like that we can merge gRPC service from cometbft for celestia-core: cometbft/cometbft#2693

@rach-id
Copy link
Member

rach-id commented Oct 9, 2024

Does #1513 closes this too? or something else is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants