Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking file processing functions and let it replace system() that do the same things #45

Open
2 of 17 tasks
holishing opened this issue Apr 18, 2019 · 2 comments
Open
2 of 17 tasks

Comments

@holishing
Copy link
Member

holishing commented Apr 18, 2019

  • file processing functions: functions in lib/file.c mainly, other related functions also should be considerated.
    • f_cat
    • f_cp
    • f_img
    • f_ln
    • f_exlock
    • f_unlock
    • f_map
    • f_mode
    • f_mv
    • f_new
    • f_open
    • f_rm
    • f_suck
    • directory functions
    • others
  • system() functions for processing files: these functions process file via system shell, it should be replaced after checking there's no problem in file processing functions for BBS, or directly use existing functions in standard C libraries.
holishing added a commit that referenced this issue Apr 19, 2019
@holishing
Copy link
Member Author

fd20343 f412834

@IepIweidieng
Copy link
Member

For system() calls, they should be replaced with wrapper functions to execv() if no well-tested substitutions are currently available.

Initial works are done in #64 by the introducing of such wrapper functions in lib/proc.c.

Now, only system() calls which use pipes and/or redirections are left and need to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants