Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compareToReference handles zeroes in reference poorly #82

Open
JocelynSP opened this issue Jan 14, 2020 · 0 comments
Open

compareToReference handles zeroes in reference poorly #82

JocelynSP opened this issue Jan 14, 2020 · 0 comments

Comments

@JocelynSP
Copy link
Contributor

Hi,

I want to compare the copy numbers of a mouse pup bam to the parents.
Example:
CopynumsNormed has 3 samples in order: parent1, parent2, pup
pupVparent1 <- compareToReference( CopynumsNormed, c( NA, FALSE, 1 ) )
gives me the pup copy numbers scaled by parent 1, and parent 1 unchanged.

All the mice have deletions compared to the mm10 reference. Where the parent copy number is 0, the scaled value for the pup is also 0, regardless of the pup copy number.
This is quite misleading output. It makes bins which are missing in both look like a new deletion in the pup. If a bin is empty in a parent but present in the pup, it still looks like a deletion when it is actually more similar to an amplification

I think it would be better to add a small value to zero scores before scaling.
Then
0/0 -> 1
small-value / 0 -> 1 + delta
moderate-value / 0 -> very-large-value

Jocelyn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant