More prominent selection color

[malteesch]

Is there an existing issue outlining your improvement?

• I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?

I suggest using a more prominent color for selected items.
I tried to fiddle with the theme a bit and got somewhat far. I ran into issues with the foreground then being too light to read. Before putting any further work into it I'd like to know if such a contribution is wanted.

Reason:

I use the "Recent Files" switcher very often and select specific files by typing.
Sometimes more than one file name fuzzily matches my desired file.
If the other matching files then are test or ignored files it is really difficult to spot which one is the selected one.

See the image:

[sgoudham]

Hey 👋,

Yeah the selection colour is a bit of a tough one. I'm not sure if I'd accept a contribution changing it again since it's already been changed so many times.

It might be worth changing the colour of the test/ignored files on your local IDE? Or disabling that completely.

[malteesch]

Hey!

Thanks for the fast response!

I see. I disabled it to see how it looks, I'd be fine disabling it but the match highlights also make it hard to see which one is selected.

I'll probably try to play with the theme a bit and see if I find a solution that works for me.
I'd post it here when I find one.
Do you want me to keep the issue open or just create a PR then and we'll see if it gets added or not?

[sgoudham]

I think it's fine to keep the issue open and I appreciate your willingness to contribute!

I'm currently working on a refactor of the underlying theming system in #163 and will most likely revisit the selection highlights there to see if it can stand out more.

I believe "problem" comes from the fact that the default selection highlight is tailored towards selecting code and some tradeoffs had to be made in order to ensure that the line background highlight had enough contrast against the selection. It might be easy to find an override for just the user interface.