Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change casper-node logs from RPC/binary-port to INFO if they return errors to users #4673

Open
sacherjj opened this issue Apr 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sacherjj
Copy link
Contributor

sacherjj commented Apr 22, 2024

When a call is made to RPC that produces a client error, we also receive an ERROR level log in the casper-node log, such as:

fields: {
   "deploy_hash": "deploy-hash(9c45..119f)",
   "err": "invalid payment: missing \"amount\" arg",
   "message": "DeployBuffer: deploy footprint exceeds tolerances"
}

We need to change client errors from calling the RPC, to INFO level on the casper-node logs.
Logging here should be INFO as there is nothing on the server we can do about it.

By having ERROR logs for client calls, we get alerts on the server due to ERRORS which have nothing to do with server operation or configuration.

@sacherjj sacherjj added the bug Something isn't working label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant