Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartctl_devices metric (and others) are often incorrect #283

Open
aieri opened this issue Aug 1, 2024 · 1 comment · May be fixed by #340
Open

smartctl_devices metric (and others) are often incorrect #283

aieri opened this issue Aug 1, 2024 · 1 comment · May be fixed by #340

Comments

@aieri
Copy link
Contributor

aieri commented Aug 1, 2024

In a standard server with a hardware HBA, the devices count is generally incorrect. This then causes the missing devices count to also be wrong. This issue is visible in the default documentation screenshot, which was pulled from a server in our lab that has 4 block devices (thankfully the screenshot itself isn't necessarily wrong - it could be displaying the correct output of a different server).

This is due to prometheus-community/smartctl_exporter#236; we could work around this by performing some level of hardware autodetection in the charm layer and configuring the exporter appropriately. Switching to a different exporter is also potentially an option.

@aieri
Copy link
Contributor Author

aieri commented Oct 23, 2024

additionally, I don't think the way we calculate missing devices makes sense, that difference should always be 0. We should consider dropping the panel.

@Deezzir Deezzir linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant