Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the usage of /etc/hardware-exporter-config.yaml #230

Open
chanchiwai-ray opened this issue Apr 26, 2024 · 2 comments
Open

Deprecate the usage of /etc/hardware-exporter-config.yaml #230

chanchiwai-ray opened this issue Apr 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@chanchiwai-ray
Copy link
Contributor

The prometheus-hardware-exporter accept command line flags instead of config file. We should directly render the config file as the command line flag in the hardware-exporter.service.j2. This will reduce our effort to maintain two config files.

@chanchiwai-ray chanchiwai-ray added the enhancement New feature or request label Apr 26, 2024
@aieri
Copy link
Contributor

aieri commented Jul 11, 2024

@chanchiwai-ray I suspect that most if not all changes would end up in the config file, and not in the systemd service (meaning that we already kind of are maintaining only one of those two). Why would it be better to move the config values to CLI options?

@chanchiwai-ray
Copy link
Contributor Author

This was only to make the charm code cleaner: we don't need to explicitly render config -> render service -> start service when installing the exporter, but that's more of a refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants