-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ubuntu Pro in Docker images #48
Comments
@dosaboy do you have the access to create github actions secrets for the project (to store the token)? Or who do we talk to about that? |
@lathiat yep ill get that sorted |
lathiat
added a commit
to lathiat/athena-core
that referenced
this issue
Jun 27, 2023
Build docker images with Ubuntu Pro to get relevant security fixes. If a non-commented "token:" line exists in the secret but the attachment fails, the build will error. However if no token exists it will not error and build without Ubuntu Pro. This is to ensure the GitHub action fails if the token becomes invalid but also allows for local development without a token. For local builds, the file pro-attach-config.yaml is used. Set a token to build with Ubuntu Pro. For GitHub actions, create a secret called PRO_ATTACH_CONFIG with the same contents as as pro-attach-config.yaml file. Closes: canonical#48
lathiat
added a commit
to lathiat/athena-core
that referenced
this issue
Jun 27, 2023
Build docker images with Ubuntu Pro to get relevant security fixes. If a non-commented "token:" line exists in the secret but the attachment fails, the build will error. However if no token exists it will not error and build without Ubuntu Pro. This is to ensure the GitHub action fails if the token becomes invalid but also allows for local development without a token. For local builds, the file pro-attach-config.yaml is used. Set a token to build with Ubuntu Pro. For GitHub actions, create a secret called PRO_ATTACH_CONFIG with the same contents as as pro-attach-config.yaml file. Closes: canonical#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're using a bunch of universe packages and processing untrusted user input. We should enable Ubuntu Pro.
Details:
https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/howtoguides/enable_in_dockerfile.html
The text was updated successfully, but these errors were encountered: