feat: generate python class interface from protobuf #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command for generation with .pyi: python -m grpc_tools.protoc --proto_path=. --python_out=. --grpc_python_out=. --pyi_out=. ./pyzeebe/proto/gateway.proto
mypy-protobuf is more precise in the generated interface.
|
Hi. Why not fix it in |
…-python-class-interface-protobuf
|
The reasoning was that we could track changes more closely if we maintained it ourselves, which I think is even more important if we use the mypy option. Secondly, it's the interfaces for connecting to zeebe that we are programming against, especially when using typing. My understanding is that the interface belongs in the package itself. By the way, which version do you prefer, mypy or just the pyi? |
|
I think this package shouldn't be a part of pyzeebe:
|
|
Hello,
Kind Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
Changes
protodirectory for protobuf and the generated stub and interface fileszeebe-grpcAPI Updates
New Features (required)
Latest version of Zeebe API (GRPC) proto.
Command for generation with .pyi:
or with mypy
Deprecations (required)
Package
zeebe-grpcis no longer used. And is removed rompyproject.tomlRemoved all traces of zeebe-grpc and exchanged for the new stubs and interface files generated from
.protoEnhancements (optional)
Now
.pyiinterface file is available and supports better type hints.Checklist
References
https://grpc.io/docs/languages/python/basics/#generating-client-and-server-code
https://mypy.readthedocs.io/en/stable/stubs.html
Resolves #475