Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Move Describable to methodical.interface #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AbhinavOmprakash
Copy link

@AbhinavOmprakash AbhinavOmprakash commented Oct 18, 2022

Thanks for contributing to Methodical. Before open a pull request, please take a moment to:

  • Ensure the PR follows the Clojure Style Guide.

  • Tests and linters pass. You can run all of the tests and linters locally with

    ./scripts/lint-and-test.sh
    

    GitHub Actions will also run these same tests against your PR.

  • Make sure you've included new tests for any new features or bugfixes.

  • New features are documented, or documentation is updated appropriately for any changed features.

  • Carefully review your own changes and revert any superfluous ones. (A good example would be moving words in the
    Markdown documentation to different lines in a way that wouldn't change how the rendered page itself would
    appear. These sorts of changes make a PR bigger than it needs to be, and, thus, harder to review.)

    Of course, indentation and typo fixes are not covered by this rule and are always appreciated.
    
  • Include a detailed explanation of what changes you're making and why you've made them. This will help me
    understand what's going on while we review it.

Once you've done all that, open a PR! Thanks for your contribution!

This PR closes #128

  • I have moved the contents of the file methodical.util.describe to methodical.interface.
  • I have refactored the occurrences of Describable as well.
  • And I've deleted the methodical.util.describe namespace.
  • The diff looks bigger than it is because of my formatter. I couldn't find a formatter in the deps.edn file (so let me know if you want me to reformat it with a specific formatter with a specific config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant