diff --git a/code/Test_definitions/qod-provisioning-createProvisioning.feature b/code/Test_definitions/qod-provisioning-createProvisioning.feature index 2415c9d6b..087066f48 100644 --- a/code/Test_definitions/qod-provisioning-createProvisioning.feature +++ b/code/Test_definitions/qod-provisioning-createProvisioning.feature @@ -113,7 +113,7 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation createProvisioning And the response property "$.message" contains a user friendly text @qod_provisioning_createProvisioning_400.4_device_empty - Scenario Outline: The device value is an empty object + Scenario: The device value is an empty object Given the request body property "$.device" is set to: {} When the request "createProvisioning" is sent Then the response status code is 400 @@ -184,7 +184,6 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation createProvisioning And the response property "$.code" is "INVALID_TOKEN" or "INVALID_ARGUMENT" And the response property "$.message" contains a user friendly text - # TBD if we neeed a dedicated code @qod_provisioning_createProvisioning_400.9_non_existent_qos_profile Scenario: Non existent QoS profile @@ -263,7 +262,6 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation createProvisioning And the response property "$.code" is "DEVICE_NOT_FOUND" And the response property "$.message" contains a user friendly text - # Errors 409 @qod_provisioning_createProvisioning_409.1_provisioning_conflict diff --git a/code/Test_definitions/qod-provisioning-deleteProvisioning.feature b/code/Test_definitions/qod-provisioning-deleteProvisioning.feature index 0d2fccb12..b50cadb64 100644 --- a/code/Test_definitions/qod-provisioning-deleteProvisioning.feature +++ b/code/Test_definitions/qod-provisioning-deleteProvisioning.feature @@ -74,7 +74,7 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation deleteProvisioning And the path parameter "provisoningId" is set to the value for that QoD provisioning When the request "deleteProvisioning" is sent Then the response status code is 202 - When the asynchronous deletion process is completed + And when the asynchronous deletion process is completed Then an event is received at the address of the "$.sink" provided for createProvisioning And the event header "Authorization" is set to "Bearer: " + the value of "$.sinkCredentials.accessToken" provided for createProvisioning And the event header "Content-Type" is set to "application/cloudevents+json" @@ -164,4 +164,3 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation deleteProvisioning And the response property "$.status" is 404 And the response property "$.code" is "NOT_FOUND" And the response property "$.message" contains a user friendly text - diff --git a/code/Test_definitions/qod-provisioning-retrieveProvisioningByDevice.feature b/code/Test_definitions/qod-provisioning-retrieveProvisioningByDevice.feature index 1c95d40d5..66faf1889 100644 --- a/code/Test_definitions/qod-provisioning-retrieveProvisioningByDevice.feature +++ b/code/Test_definitions/qod-provisioning-retrieveProvisioningByDevice.feature @@ -75,7 +75,7 @@ Feature: CAMARA QoD Provisioning API, v0.1.0 - Operation retrieveProvisioningByD And the response property "$.message" contains a user friendly text @qod_provisioning_retrieveProvisioningByDevice_400.4_device_empty - Scenario Outline: The device value is an empty object + Scenario: The device value is an empty object Given the request body property "$.device" is set to: {} When the request "retrieveProvisioningByDevice" is sent Then the response status code is 400 diff --git a/code/Test_definitions/qos-profiles-retrieveQoSProfiles.feature b/code/Test_definitions/qos-profiles-retrieveQoSProfiles.feature index 8b7e2a9c2..b9ffd9ab1 100644 --- a/code/Test_definitions/qos-profiles-retrieveQoSProfiles.feature +++ b/code/Test_definitions/qos-profiles-retrieveQoSProfiles.feature @@ -11,7 +11,6 @@ Feature: CAMARA QoS Profiles API, v0.11.0 - Operation retrieveQoSProfiles # * If some QoS Profile is restricted for some devices, provide the QoS profile name and device # * A device object identifying a device commercialized by the implementation for which the service is not applicable, if any - # References to OAS spec schemas refer to schemas specifies in qos-profiles.yaml, version 0.11.0 Background: Common retrieveQoSProfiles setup @@ -97,7 +96,6 @@ Feature: CAMARA QoS Profiles API, v0.11.0 - Operation retrieveQoSProfiles And the response header "x-correlator" has same value as the request header "x-correlator" And the response body is [] - # Errors 400 @qos_profiles_retrieveQoSProfiles_400.1_schema_not_compliant @@ -179,7 +177,6 @@ Feature: CAMARA QoS Profiles API, v0.11.0 - Operation retrieveQoSProfiles And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 @qos_profiles_retrieveQoSProfiles_403.1_device_token_mismatch diff --git a/code/Test_definitions/quality-on-demand-createSession.feature b/code/Test_definitions/quality-on-demand-createSession.feature index 5d6a38b1c..7f2ae3e14 100644 --- a/code/Test_definitions/quality-on-demand-createSession.feature +++ b/code/Test_definitions/quality-on-demand-createSession.feature @@ -99,7 +99,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation createSession And the response property "$.code" is "INVALID_ARGUMENT" And the response property "$.message" contains a user friendly text - @quality_on_demand_createSession_400.2_no_request_body Scenario: Missing request body Given the request body is not included @@ -274,7 +273,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation createSession And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 @quality_on_demand_createSession_403.1_device_token_mismatch @@ -305,7 +303,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation createSession And the response property "$.code" is "DEVICE_NOT_FOUND" And the response property "$.message" contains a user friendly text - # Errors 409 @quality_on_demand_createSession_409.1_session_conflict diff --git a/code/Test_definitions/quality-on-demand-deleteSession.feature b/code/Test_definitions/quality-on-demand-deleteSession.feature index e964e1b9d..cbbca9e10 100644 --- a/code/Test_definitions/quality-on-demand-deleteSession.feature +++ b/code/Test_definitions/quality-on-demand-deleteSession.feature @@ -9,7 +9,7 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation deleteSession # * The sessionId of an existing session with status "AVAILABLE", and with provided values for "sink" and "sinkCredential". # * The sessionId of an existing session with status "UNAVAILABLE", and with provided values for "sink" and "sinkCredential". # - # References to OAS spec schemas refer to schemas specifies in quality-on-demand.yaml, version 0.11.0 + # References to OAS spec schemas refer to schemas specifies in quality-on-demand.yaml, version 0.11.0-rc.1 Background: Common deleteSession setup Given an environment at "apiRoot" @@ -97,14 +97,13 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation deleteSession And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 # TBD which code is more appropriate for this scenario @quality_on_demand_deleteSession_403.1_session_token_mismatch Scenario: QoS session not created by the API client given in the access token # To test this, a token have to be obtained for a different client - Given the header "Authorization" is set to a valid access token emitted to a client which did not created the QoS session And the header "Authorization" is set to a valid access token emitted for a different device + Given the header "Authorization" is set to a valid access token emitted to a client which did not created the QoS session When the request "deleteSession" is sent Then the response status code is 403 And the response header "x-correlator" has same value as the request header "x-correlator" diff --git a/code/Test_definitions/quality-on-demand-extendQosSessionDuration.feature b/code/Test_definitions/quality-on-demand-extendQosSessionDuration.feature index 38b45f855..c14f1b360 100644 --- a/code/Test_definitions/quality-on-demand-extendQosSessionDuration.feature +++ b/code/Test_definitions/quality-on-demand-extendQosSessionDuration.feature @@ -60,7 +60,7 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation extendQosSessionDurat # To be discussed. Behaviour when the qosStatus of the session is REQUESTED @quality_on_demand_extendQosSessionDuration_03_requestedSession - Scenario: Response extending duration for unavailable session + Scenario: Response extending duration for requested session Given an existing QoS session created by operation createSession with qosStatus "REQUESTED" And the path parameter "sessionId" is set to the value for that QoS session And the request body is set to a valid request body @@ -94,7 +94,7 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation extendQosSessionDurat # 404 NOT_FOUND is an alternative if path parameter format is not validated @quality_on_demand_extendQosSessionDuration_400.2_invalid_session_id - Scenario: Invalid Argument. Generic Syntax Exception + Scenario: Invalid sessionId Given the path parameter "sessionId" has not a UUID format When the request "extendQosSessionDuration" is sent Then the response status code is 400 @@ -164,14 +164,13 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation extendQosSessionDurat And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 # TBD which code is more appropriate for this scenario @quality_on_demand_extendQosSessionDuration_403.1_session_token_mismatch Scenario: QoS session not created by the API client given in the access token # To test this, a token have to be obtained for a different client - Given the header "Authorization" is set to a valid access token emitted to a client which did not created the QoS session And the header "Authorization" is set to a valid access token emitted for a different device + Given the header "Authorization" is set to a valid access token emitted to a client which did not created the QoS session When the request "extendQosSessionDuration" is sent Then the response status code is 403 And the response header "x-correlator" has same value as the request header "x-correlator" diff --git a/code/Test_definitions/quality-on-demand-getSession.feature b/code/Test_definitions/quality-on-demand-getSession.feature index 94d6f9863..1a305242c 100644 --- a/code/Test_definitions/quality-on-demand-getSession.feature +++ b/code/Test_definitions/quality-on-demand-getSession.feature @@ -103,7 +103,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation getSession And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 # TBD which code is more appropriate for this scenario diff --git a/code/Test_definitions/quality-on-demand-retrieveSessionsByDevice.feature b/code/Test_definitions/quality-on-demand-retrieveSessionsByDevice.feature index b17ae50a3..71b71927b 100644 --- a/code/Test_definitions/quality-on-demand-retrieveSessionsByDevice.feature +++ b/code/Test_definitions/quality-on-demand-retrieveSessionsByDevice.feature @@ -55,7 +55,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation retrieveSessionsByDev And the response header "x-correlator" has same value as the request header "x-correlator" And the response body is [] - # Errors 400 @quality_on_demand_retrieveSessionsByDevice_400.1_schema_not_compliant @@ -69,7 +68,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation retrieveSessionsByDev And the response property "$.code" is "INVALID_ARGUMENT" And the response property "$.message" contains a user friendly text - @quality_on_demand_retrieveSessionsByDevice_400.2_no_request_body Scenario: Missing request body Given the request body is not included @@ -174,7 +172,6 @@ Feature: CAMARA Quality On Demand API, v0.11.0 - Operation retrieveSessionsByDev And the response property "$.code" is "UNAUTHENTICATED" And the response property "$.message" contains a user friendly text - # Errors 403 @quality_on_demand_retrieveSessionsByDevice_403.1_device_token_mismatch