Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" to "INVALID_TOKEN_CONTEXT" #141

Closed
AxelNennker opened this issue Aug 28, 2024 · 2 comments

Comments

@AxelNennker
Copy link
Collaborator

AxelNennker commented Aug 28, 2024

Problem description
While reviewing 1.1 for ICM I noticed that we still "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" in the yaml file once.
camaraproject/IdentityAndConsentManagement#189 (comment)

We changed that to "INVALID_TOKEN_CONTEXT" some lines lower.

Why did we not change it in this line?
https://github.com/camaraproject/NumberVerification/blob/r1.1/code/API_definitions/number_verification.yaml#L271

Expected behavior
Change "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" to "INVALID_TOKEN_CONTEXT"

@bigludo7
Copy link
Collaborator

This is a valid point

The fix has been done by @fernandopradocabrillo last week and it appears on the yaml.
But I do not understand why this change is not reflected on the PR39 - files changed part.

@bigludo7
Copy link
Collaborator

Fixed in r1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants