-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIBA in Camara OpenAPI yaml files #209
Comments
Since ICM defines the guidelines for what refers to securitySchemes in API Specs, and considering that this topic has already been discussed and agreed in ICM in the past. I would suggest that this topic be moved to ICM. |
I agree. This document describes how a transfer could be done, but it seems I do not have the right permissions to transfer this issue. So, I am going to create a new in ICM. |
I created an issue in ICM camaraproject/IdentityAndConsentManagement#157 |
Thanks Axel. I guess we can close this one then. |
I would like to keep the issue for now until Commonalities decides what to do with OpenAPI definitions. Maybe Commonalities decides to add some backlog-label?! There is maybe/probably not enough time to integrate a CIBA security scheme into this release but I think, given the importance of CIBA for telcos, there should be a guideline for API designers on CIBA. Option 1: I think that OpenAPI definitions should be in one place. Currently OpenAPI Definitions are in Commonalities OpenAPI definitions. Commonalities could incorporate the security schemes agreed upon in ICM. Thinking about "release documents", developers and API designers should find relevant information on ONE topic in ONE place not scattered over several documents that link to each other. There should be not too many release documents. |
Option 4: Leave it as it is which IMHO it's more than fine. I don't see what is the problem with current state. The
@AxelNennker What is exactly the problem of including a reference in
Why should we move this content from ICM |
As I said, I think there is no such thing as "ownership". ICM was founded out of Commonalities because identity and consent is a big enough topic and e.g. the Security and Interoperability Profile is a valuable result of ICM. OpenAPI Definitions are in Commonalities API Design guidelines in the OpenAPI Definitions section and I think that OpenAPI security schemes should also be there, so that API designers have all OpenAPI definitions in one document. |
Fully agree. But it is a fact that there are different working groups and each of them working and maintaining documents on each github subproject. Please, don't get wrong. |
All's good. We just seem to disagree where the OpenAPI definitions text on security schemes should be. Some view ICM as a subgroup of Commonalities. Whether one shares this view or not, I think that ICM is about Identity and Consent and the API guidelines have on OpenAPI definitions section. I propose that Commonalities put the ICM defined OIDC and CIBA (later?) security schemes into OpenAPI definitions. |
@rartych Now that PR #208 is MERGED and issue 207 is CLOSED. After transferring the issue to ICM camaraproject/IdentityAndConsentManagement#157, I think we can close this issue. |
I think we can close this issue, after transferring and managed it in I&CM WG |
Closing the issue in Commonalities. |
Problem description
Camara API OpenAPI yaml files should list the security schemes they offer or even require e.g. for OIDC and CIBA.
ICM defined a security scheme for OIDC but not for CIBA.
There is an issue in ICM to discuss an OpenAPI security scheme for CIBA.
** Solution **
After ICM defined an CIBA security scheme Camara API design guidelines should incorporate it into the existing OpenAPI definitions
Note: I, Axel, am speaking here as me not as a ICM maintainer/codeowner/chair. It is Commonalities decision how to write API design guidelines. Commonalities could integrate OpenAPI security schemes into the existing section or move the whole "OpenAPI defintions" sections into a separate document "owned" by ICM.
The text was updated successfully, but these errors were encountered: