Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount syscall has wrong parameters #1025

Open
morr0ne opened this issue Feb 28, 2024 · 0 comments
Open

Mount syscall has wrong parameters #1025

morr0ne opened this issue Feb 28, 2024 · 0 comments

Comments

@morr0ne
Copy link
Contributor

morr0ne commented Feb 28, 2024

The current mount syscall implementation is incorrect since it does not allow for source, filesystemtype and data to be null.

I opened a pr (#1024) that adds a separate mount2 syscall. This is essentially the same but with the nullable parameters as Options.

The current mount function should be marked as deprecated and possibly removed in the next major release or eventual 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant