Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXMEs in the code #914

Open
natalieparellano opened this issue Sep 22, 2022 · 3 comments · May be fixed by #1274
Open

FIXMEs in the code #914

natalieparellano opened this issue Sep 22, 2022 · 3 comments · May be fixed by #1274
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to the this done. status/ready type/chore

Comments

@natalieparellano
Copy link
Member

Description

There are a number of (mostly) small refactors denoted with FIXME in the lifecycle code. It would be awesome if we could go through and either tackle them or create an issue for them.

@natalieparellano natalieparellano added good first issue A good first issue to get started with. type/chore status/ready labels Sep 22, 2022
@anushkamittal20
Copy link
Contributor

Hey @natalieparellano, I would like to make my first contribution to buildpacks community with this issue. I understand this might be a great issue to help understand the project and get familiar with the codebase. I see there are 18 "FIXMEs" that can be worked on, it would be great to discuss and work on them.

@natalieparellano
Copy link
Member Author

natalieparellano commented Mar 3, 2023

Welcome @anushkamittal20! We'd be grateful to have your help here :) I'd be happy to discuss further any FIXMEs you'd like to tackle. (It wouldn't be necessary to address all of them in a single PR, in fact it may be easiest to create one PR per FIXME or related set.) We can continue the conversation here, or if you prefer more real-time support, feel free to reach out in #buildpacks-implementation in CNCF Slack.

@anushkamittal20
Copy link
Contributor

Thank you @natalieparellano!
I was thinking we could go through all the FIXMEs and maybe document what we can do about them, with options being tackling them and creating a separate issue, and then I could pick a few to tackle here.
Would love to know what you think.
I will continue this conversation over the slack channel as you suggested!
Again thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to the this done. status/ready type/chore
Projects
None yet
2 participants