New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision issue requiring SSR computation to bottom out as ssrDistanceMax increases. #846

Open

bryanedds opened this issue Aug 6, 2024 · 1 comment

Labels

Owner

bryanedds commented Aug 6, 2024

The precision issue is currently worked around by using max(0.000001, ...) in this line of code -

currentDistanceView = -startView.z * -stopView.z / max(0.00001, mix(-stopView.z, -startView.z, currentProgressB)); // NOTE: uses perspective correct interpolation for depth, but causes precision issues as ssrDistanceMax increases.

You can see where it bottoms out the reflection computation here -

If we could find some way to preserve intended behavior without losing precision to the point of bottoming out, that should address this issue.

The text was updated successfully, but these errors were encountered:

bryanedds added the enhancement label

bryanedds added a commit that referenced this issue


          Reduced SsrDistanceMaxDefault to workaround #846 a bit.

5f2ef18

Owner Author

bryanedds commented Aug 6, 2024 •

edited

Loading

Worked around this a bit by changing SSR config defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment